Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-9272: Upgrade to Nx 18 #436

Merged
merged 4 commits into from
Apr 16, 2024
Merged

HPC-9272: Upgrade to Nx 18 #436

merged 4 commits into from
Apr 16, 2024

Conversation

Pl217
Copy link
Contributor

@Pl217 Pl217 commented Apr 15, 2024

No description provided.

Pl217 added 4 commits April 15, 2024 17:38
This commit is generated by running the following command:
`npx nx migrate 17.3.2`

This has changed `package.json` and updated all Nx
packages, but also a few other. Manual changes were
made to prevent downgrading of following packages:
* `@types/node`: Downgrade to `18.19.31` attempted
* `eslint`: Downgrade to `8.48.0` attempted

The CLI has also done major upgrades to dependencies
which Nx has as peer dependencies, which was required
in the same commit, because installation would
fail otherwise:
* Major version upgrade of packages
`@typescript-eslint/eslint-plugin` and
`@typescript-eslint/parser` to `6.21.0`
* Major version upgrade of `eslint-config-prettier` to `9.1.0`

Also, some non-Nx packages were updated, but manually
reverted because they will be updated in a separate commit:
* Patch update of `@types/react` to `18.2.24`
* Patch update of `@types/react-dom` to `18.2.9`
* Patch update of `@types/react-is` to `18.2.2`
* Minor update of `eslint-plugin-cypress` to `2.15.1`
* Minor update of `typescript` to `5.3.3`

Besides package updates, `nx migrate` command also
generated `migrations.json` file, which should not
be committed, but will be used as a blueprint for
migrations in the next step, when we run
`npx nx migrate --run-migrations`
This commit is the output of running command
`npx nx migrate --run-migrations`

Full output of command run:

 NX   Running 'npm install' to make sure necessary packages are installed

...

 >  NX   Running migrations from 'migrations.json'

Ran 17.0.0-move-cache-directory from nx
  Updates the default cache directory to .nx/cache

  UPDATE .gitignore
  UPDATE .prettierignore
---------------------------------------------------------
Ran 17.0.0-use-minimal-config-for-tasks-runner-options from nx
  Use minimal config for tasksRunnerOptions

  UPDATE nx.json
---------------------------------------------------------
[object Object]
Ran rm-default-collection-npm-scope from nx
  Migration for v17.0.0-rc.1

  UPDATE nx.json
---------------------------------------------------------
Ran update-16-7-0-add-typings from @nx/react
  Add @nx/react types to tsconfig types array

  UPDATE apps/hpc-cdm/tsconfig.app.json
  UPDATE apps/hpc-cdm/tsconfig.spec.json
  UPDATE apps/hpc-ftsadmin/tsconfig.app.json
  UPDATE apps/hpc-ftsadmin/tsconfig.spec.json
---------------------------------------------------------
Ran move-options-to-target-defaults from @nx/jest
  Move jest executor options to nx.json targetDefaults

  UPDATE nx.json
  UPDATE apps/hpc-cdm/project.json
  UPDATE apps/hpc-ftsadmin/project.json
  UPDATE libs/hpc-core/project.json
  UPDATE libs/hpc-data/project.json
  UPDATE libs/hpc-dummy/project.json
  UPDATE libs/hpc-live/project.json
  UPDATE libs/hpc-ui/project.json
---------------------------------------------------------
Ran update-17-0-0-rename-to-eslint from @nx/linter
  update-17-0-0-rename-to-eslint

  UPDATE package.json
  UPDATE apps/hpc-cdm/project.json
  UPDATE apps/hpc-cdm-e2e/project.json
  UPDATE apps/hpc-ftsadmin/project.json
  UPDATE apps/hpc-ftsadmin-e2e/project.json
  UPDATE libs/hpc-core/project.json
  UPDATE libs/hpc-data/project.json
  UPDATE libs/hpc-dummy/project.json
  UPDATE libs/hpc-live/project.json
  UPDATE libs/hpc-ui/project.json
  UPDATE migrations.json
---------------------------------------------------------
Ran simplify-eslint-patterns from @nx/linter
  Simplify eslintFilePatterns

  UPDATE apps/hpc-cdm/project.json
  UPDATE apps/hpc-cdm-e2e/project.json
  UPDATE apps/hpc-ftsadmin/project.json
  UPDATE apps/hpc-ftsadmin-e2e/project.json
  UPDATE libs/hpc-core/project.json
  UPDATE libs/hpc-data/project.json
  UPDATE libs/hpc-dummy/project.json
  UPDATE libs/hpc-live/project.json
  UPDATE libs/hpc-ui/project.json
---------------------------------------------------------
Ran move-options-to-target-defaults from @nx/linter
  Move executor options to target defaults

  UPDATE nx.json
---------------------------------------------------------

 >  NX   Running 'npm install' to make sure necessary packages are installed

...

 >  NX   Successfully finished running migrations from 'migrations.json'. This workspace is up to date!
This commit is generated by running the following command:
`npx nx migrate 18.2.4`

Besides package updates, `nx migrate` command also
generated `migrations.json` file, which should not
be committed, but will be used as a blueprint for
migrations in the next step, when we run
`npx nx migrate --run-migrations`
This commit is the output of running command
`npx nx migrate --run-migrations`

Full output of command run:

 NX   Running 'npm install' to make sure necessary packages are installed

...

 NX   Running migrations from 'migrations.json'

Ran 18.0.0-disable-adding-plugins-for-existing-workspaces from nx
  Updates nx.json to disabled adding plugins when generating projects in an existing Nx workspace

  UPDATE nx.json
---------------------------------------------------------
Ran move-default-base-to-nx-json-root from nx
  Moves affected.defaultBase to defaultBase in `nx.json`

  UPDATE nx.json
---------------------------------------------------------

 NX   Successfully finished running migrations from 'migrations.json'. This workspace is up to date!
@Pl217 Pl217 added the ready for review All comments have been addressed, and the Pull Request is ready for review label Apr 15, 2024
@Pl217 Pl217 requested a review from a team as a code owner April 15, 2024 15:40
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Delgee Delgee assigned Pl217 and unassigned Delgee Apr 16, 2024
@Delgee Delgee added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Apr 16, 2024
@Pl217 Pl217 merged commit 9768527 into develop Apr 16, 2024
3 checks passed
@Pl217 Pl217 deleted the HPC-9272 branch April 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants