-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPC-9272: Upgrade to Nx 18 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is generated by running the following command: `npx nx migrate 17.3.2` This has changed `package.json` and updated all Nx packages, but also a few other. Manual changes were made to prevent downgrading of following packages: * `@types/node`: Downgrade to `18.19.31` attempted * `eslint`: Downgrade to `8.48.0` attempted The CLI has also done major upgrades to dependencies which Nx has as peer dependencies, which was required in the same commit, because installation would fail otherwise: * Major version upgrade of packages `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` to `6.21.0` * Major version upgrade of `eslint-config-prettier` to `9.1.0` Also, some non-Nx packages were updated, but manually reverted because they will be updated in a separate commit: * Patch update of `@types/react` to `18.2.24` * Patch update of `@types/react-dom` to `18.2.9` * Patch update of `@types/react-is` to `18.2.2` * Minor update of `eslint-plugin-cypress` to `2.15.1` * Minor update of `typescript` to `5.3.3` Besides package updates, `nx migrate` command also generated `migrations.json` file, which should not be committed, but will be used as a blueprint for migrations in the next step, when we run `npx nx migrate --run-migrations`
This commit is the output of running command `npx nx migrate --run-migrations` Full output of command run: NX Running 'npm install' to make sure necessary packages are installed ... > NX Running migrations from 'migrations.json' Ran 17.0.0-move-cache-directory from nx Updates the default cache directory to .nx/cache UPDATE .gitignore UPDATE .prettierignore --------------------------------------------------------- Ran 17.0.0-use-minimal-config-for-tasks-runner-options from nx Use minimal config for tasksRunnerOptions UPDATE nx.json --------------------------------------------------------- [object Object] Ran rm-default-collection-npm-scope from nx Migration for v17.0.0-rc.1 UPDATE nx.json --------------------------------------------------------- Ran update-16-7-0-add-typings from @nx/react Add @nx/react types to tsconfig types array UPDATE apps/hpc-cdm/tsconfig.app.json UPDATE apps/hpc-cdm/tsconfig.spec.json UPDATE apps/hpc-ftsadmin/tsconfig.app.json UPDATE apps/hpc-ftsadmin/tsconfig.spec.json --------------------------------------------------------- Ran move-options-to-target-defaults from @nx/jest Move jest executor options to nx.json targetDefaults UPDATE nx.json UPDATE apps/hpc-cdm/project.json UPDATE apps/hpc-ftsadmin/project.json UPDATE libs/hpc-core/project.json UPDATE libs/hpc-data/project.json UPDATE libs/hpc-dummy/project.json UPDATE libs/hpc-live/project.json UPDATE libs/hpc-ui/project.json --------------------------------------------------------- Ran update-17-0-0-rename-to-eslint from @nx/linter update-17-0-0-rename-to-eslint UPDATE package.json UPDATE apps/hpc-cdm/project.json UPDATE apps/hpc-cdm-e2e/project.json UPDATE apps/hpc-ftsadmin/project.json UPDATE apps/hpc-ftsadmin-e2e/project.json UPDATE libs/hpc-core/project.json UPDATE libs/hpc-data/project.json UPDATE libs/hpc-dummy/project.json UPDATE libs/hpc-live/project.json UPDATE libs/hpc-ui/project.json UPDATE migrations.json --------------------------------------------------------- Ran simplify-eslint-patterns from @nx/linter Simplify eslintFilePatterns UPDATE apps/hpc-cdm/project.json UPDATE apps/hpc-cdm-e2e/project.json UPDATE apps/hpc-ftsadmin/project.json UPDATE apps/hpc-ftsadmin-e2e/project.json UPDATE libs/hpc-core/project.json UPDATE libs/hpc-data/project.json UPDATE libs/hpc-dummy/project.json UPDATE libs/hpc-live/project.json UPDATE libs/hpc-ui/project.json --------------------------------------------------------- Ran move-options-to-target-defaults from @nx/linter Move executor options to target defaults UPDATE nx.json --------------------------------------------------------- > NX Running 'npm install' to make sure necessary packages are installed ... > NX Successfully finished running migrations from 'migrations.json'. This workspace is up to date!
This commit is generated by running the following command: `npx nx migrate 18.2.4` Besides package updates, `nx migrate` command also generated `migrations.json` file, which should not be committed, but will be used as a blueprint for migrations in the next step, when we run `npx nx migrate --run-migrations`
This commit is the output of running command `npx nx migrate --run-migrations` Full output of command run: NX Running 'npm install' to make sure necessary packages are installed ... NX Running migrations from 'migrations.json' Ran 18.0.0-disable-adding-plugins-for-existing-workspaces from nx Updates nx.json to disabled adding plugins when generating projects in an existing Nx workspace UPDATE nx.json --------------------------------------------------------- Ran move-default-base-to-nx-json-root from nx Moves affected.defaultBase to defaultBase in `nx.json` UPDATE nx.json --------------------------------------------------------- NX Successfully finished running migrations from 'migrations.json'. This workspace is up to date!
Pl217
added
the
ready for review
All comments have been addressed, and the Pull Request is ready for review
label
Apr 15, 2024
unocha-hpc
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks have passed and this pull request is ready for manual review
Delgee
approved these changes
Apr 16, 2024
Delgee
added
ready for merge
Review and testing is complete. It is ready for merging as soon as CI has finished.
and removed
ready for review
All comments have been addressed, and the Pull Request is ready for review
labels
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready for merge
Review and testing is complete. It is ready for merging as soon as CI has finished.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.